helm chart - make .Values.router optional

[dan-catalano-vc]

• discussion #4934 (written by us)
• get liveness & readiness port from containerPorts
• check if .Values.router exists before checking if .Values.router.configuration exist
• remove .Values.router.configuration & .Values.router.args from default values.yaml

Description here

Fixes #4781 (found existing issue when looking into problem)

---

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

• [ ] Changes are compatible[^1]
• [ ] Documentation[^2] completed
• [ ] Performance impact assessed and acceptable
• Tests added and passing[^3]
  • [ ] Unit Tests
  • [ ] Integration Tests
  • [ ] Manual Tests

Exceptions

Note any exceptions here

Notes

[^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

[apollo-cla]

@dan-catalano-vc: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

[router-perf[bot]]

CI performance tests

• [ ] reload - Reload test over a long period of time at a constant rate of users
• [ ] events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
• [ ] events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
• [ ] large-request - Stress test with a 1 MB request payload
• [x] const - Basic stress test that runs with a constant number of users
• [ ] no-graphos - Basic stress test, no GraphOS.
• [ ] step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
• [ ] events - Stress test for events with a lot of users and deduplication ENABLED
• [ ] events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
• [ ] events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
• [ ] events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
• [ ] xxlarge-request - Stress test with 100 MB request payload
• [ ] xlarge-request - Stress test with 10 MB request payload
• [x] step - Basic stress test that steps up the number of users over time

[garypen]

For anyone else reading this PR: I've put some feedback on the linked discussion.

[garypen]

There's been no further activity in the linked discussion so I'm closing this.