router icon indicating copy to clipboard operation
router copied to clipboard

Enable JS / Rust API schema comparison by default

Open goto-bus-stop opened this issue 1 year ago • 2 comments

This adds the standardisation code that I used successfully for harness runs, so we should get quite robust results.

I tested this manually by adding a panic!() in the mismatch case and intentionally adding a bug in the fed-next implementation locally.

Closes #4649


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • [ ] Changes are compatible[^1]
  • [x] Documentation[^2] completed
  • [ ] Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • [ ] Unit Tests
    • [ ] Integration Tests
    • [x] Manual Tests

Exceptions

Note any exceptions here

Notes

[^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

goto-bus-stop avatar Feb 22 '24 08:02 goto-bus-stop

CI performance tests

  • [ ] reload - Reload test over a long period of time at a constant rate of users
  • [ ] events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • [ ] events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • [ ] large-request - Stress test with a 1 MB request payload
  • [x] const - Basic stress test that runs with a constant number of users
  • [ ] no-graphos - Basic stress test, no GraphOS.
  • [ ] step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • [ ] events - Stress test for events with a lot of users and deduplication ENABLED
  • [ ] events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • [ ] events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • [ ] events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • [ ] xxlarge-request - Stress test with 100 MB request payload
  • [ ] xlarge-request - Stress test with 10 MB request payload
  • [x] step - Basic stress test that steps up the number of users over time

router-perf[bot] avatar Feb 22 '24 08:02 router-perf[bot]

Wanna do one more apollo-federation release to really get this in order.

goto-bus-stop avatar Feb 22 '24 12:02 goto-bus-stop

@goto-bus-stop, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

github-actions[bot] avatar Mar 12 '24 10:03 github-actions[bot]

Filing a separate PR to change the default to both that we can land according to the release calendar, meanwhile this apollo-federation update can land now to support early experimentation with QP integration

goto-bus-stop avatar Mar 12 '24 10:03 goto-bus-stop