router icon indicating copy to clipboard operation
router copied to clipboard

set a default TTL for query plans

Open Geal opened this issue 1 year ago • 2 comments

Fix https://github.com/apollographql/router/issues/4473

This sets a default TTL for query plan caches, because right now the default is sto store query plans indefinitely, which does not make sense because they change with schema updates. The PR is a bit verbose because to add that new default, we need to create a redundant structure for redis configuration (I tried const generics but serde won't support them)


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • [ ] Changes are compatible[^1]
  • [ ] Documentation[^2] completed
  • [ ] Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • [ ] Unit Tests
    • [ ] Integration Tests
    • [ ] Manual Tests

Exceptions

Note any exceptions here

Notes

[^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

Geal avatar Feb 02 '24 16:02 Geal

CI performance tests

  • [ ] events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • [ ] events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • [ ] events - Stress test for events with a lot of users and deduplication ENABLED
  • [ ] large-request - Stress test with a 1 MB request payload
  • [x] step - Basic stress test that steps up the number of users over time
  • [ ] xlarge-request - Stress test with 10 MB request payload
  • [ ] reload - Reload test over a long period of time at a constant rate of users
  • [ ] no-graphos - Basic stress test, no GraphOS.
  • [ ] events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • [ ] xxlarge-request - Stress test with 100 MB request payload
  • [ ] step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • [ ] events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • [x] const - Basic stress test that runs with a constant number of users
  • [ ] events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode

router-perf[bot] avatar Feb 02 '24 16:02 router-perf[bot]

@Geal, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

github-actions[bot] avatar Feb 06 '24 09:02 github-actions[bot]

I think there should be some sort of documentation update associated with this. @shorgi can we add a table for the options with defaults?

BrynCooke avatar Mar 27 '24 09:03 BrynCooke

there is some documentation now

Geal avatar Apr 02 '24 13:04 Geal

actually maybe it would make sense to have a default expiration for APQ too :thinking:

Geal avatar Apr 02 '24 13:04 Geal

@BrynCooke @bnjjj @o0Ignition0o could I get a review for this PR? This has waited for 3 weeks already

Geal avatar Apr 03 '24 15:04 Geal