router icon indicating copy to clipboard operation
router copied to clipboard

additional studio tracing configuration

Open deweyjose opened this issue 2 years ago • 5 comments

Describe the solution you'd like Add support for additional Studio tracing configuration.

  • control over http headers included with studio traces
  • ability to set a Studio tracing sample rate similar to opentelemetry tracing - performance reasons.
  • ability to dynamically disable tracing in the event it impacts overall performance.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

deweyjose avatar Jul 05 '22 21:07 deweyjose

Hi, do you currently see performance issues with studio reporting in the router?

Geal avatar Jul 13 '22 07:07 Geal

Hi @Geal, we're currently in the process of discovery and planning our migration from Gateway to Router. Is the amount of data pushed to Studio significantly less than what's available with OpenTelemetry, or significantly faster in such a way that wouldn't require sampling at scale?

deweyjose avatar Jul 13 '22 13:07 deweyjose

it is less than what is sent with OpenTelemetry, because data from similar queries is aggregated (so there's only one entry per different query), and they are sent as a batch every 5 seconds. OpenTelemetry is much more granular, with multiple spans created and sent per query, and for those you can configure sampling and batch size: https://www.apollographql.com/docs/router/configuration/tracing#trace-config

Geal avatar Jul 13 '22 13:07 Geal

Relates to #74

abernix avatar Aug 12 '22 08:08 abernix

A lot of progress has been made on this in #1514 I think the only thing that is left is: Ability to dynamically disable tracing in the event it impacts overall performance.

BrynCooke avatar Sep 12 '22 08:09 BrynCooke