graphql-subscriptions icon indicating copy to clipboard operation
graphql-subscriptions copied to clipboard
verified publisher icon apollographql

fix: `withFilter` types

Open sevrai opened this issue 6 months ago • 2 comments

Thank you for the release of the V3. Nonetheless, we encoutered issues while migrating to it with Apollo v4 and graphql-codegen.

Types exposed for withFilter function do not match its implementation:

  • TSource of the filter function is the value returned by the asyncIterator
  • parameters are optionnal in types but required ligne 18. Is there a reason for this signature ?

sevrai avatar Jul 02 '25 12:07 sevrai

@sevrai: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

apollo-cla avatar Jul 02 '25 12:07 apollo-cla

Hello @tninesling,

Could you please take a look of this issue? Migrating to 3.0 of in our stack is proving to be quite challenging.

Thank you in advance for your time.

sevrai avatar Jul 15 '25 09:07 sevrai