gatsby-theme-apollo icon indicating copy to clipboard operation
gatsby-theme-apollo copied to clipboard

Remove puppeteer dependencies

Open Troy-Yang opened this issue 5 years ago • 3 comments

Hi,

I found two plugins gatsby-remark-mermaid and gatsby-plugin-printer depends on puppeteer which will download chrome instance during installing.

More importantly, it will throw an error and result to building failed durring gitlab pipeline. ` error "gatsby-plugin-printer" threw an error while running the onPostBuild lifecycle: Failed to launch chrome! /builds/xxxx/node_modules/puppeteer/.local-chromium/linux-686378/chrome-linux/chrome: error while loading shared libraries: libX11-xcb.so.1: cannot open shared object file: No such file or directory

Error: Failed to launch chrome! /builds/xxx/node_modules/puppeteer/.local-chromium/linux-686 378/chrome-linux/chrome: error while loading shared libraries: libX11-xcb.so.1 : cannot open shared object file: No such file or directory `

I am thinking whether we can remove such plugins or override to remove them?

Thanks

Troy-Yang avatar Nov 06 '20 04:11 Troy-Yang

This is a fair request. Currently, the Apollo docs depend on printer to create our social sharing cards, but I've been planning on changing this to use Cloudinary instead. Once that change is made, we'll be able to drop gatsby-plugin-printer.

I think it's reasonable for us to selectively install gatsby-plugin-mermaid on docs websites that actually use it, rather than including it in this theme. I'll work on making these changes and update this issue when I have more information.

trevorblades avatar Nov 25 '20 20:11 trevorblades

Thanks man, Looking forward!

Troy-Yang avatar Nov 27 '20 15:11 Troy-Yang

any updates ?

Carlosf96 avatar Oct 08 '21 17:10 Carlosf96