fullstack-tutorial icon indicating copy to clipboard operation
fullstack-tutorial copied to clipboard

Published 20 hours ago • verified publisher icon apollographql

login-form.tsx references a lower case non-existent interface

Open jonasatmonday opened this issue 3 years ago • 2 comments

Hello everybody,

/final/client/src/components/login-forms.tsx references LoginTypes.loginVariables from login.ts which does not exist. It needs to be LoginTypes.LoginVariables instead.

Currently, it is not possible to start the final client because of this bug.

I already prepared a commit for this fix but can't push it to a new branch because I have no push permission for this repo. How can I get the push permission for new branches?

Thanks a lot and best regards, Jonas

jonasatmonday avatar Jan 21 '21 11:01 jonasatmonday

It happens to me too. It's fixed in the commit https://github.com/apollographql/fullstack-tutorial/pull/202, but still waiting for merge.

BTW, I am somehow surprised Apollographql allows compilation error checkins to master branch.

lanshunfang avatar Mar 22 '21 21:03 lanshunfang

@lanshunfang me too! I would assume they have some CI/CD pipelines in place to prevent this kind of stuff from happening.

jonasatmonday avatar Mar 23 '21 07:03 jonasatmonday