federation icon indicating copy to clipboard operation
federation copied to clipboard

WIP: Make SchemaUpgrader faster

Open clenfest opened this issue 1 year ago • 4 comments

The idea is to make SchemaUpgrader faster by precomputing each type into a map that can be passed around once rather. Ideally we would be able to entirely get rid of otherSubgraphs as a parameter to SchemaUpgrader before this PR is ready.

Note that although this works with tests, I think there may be an issue with interfaces that isn't covered by tests, so do not merge unless someone has a chance to look at this with a critical eye. (I think the issue is that the map is built by iterating over objectTypes but later code iterates over types() which may include interfaces.

clenfest avatar Jun 28 '24 22:06 clenfest

🦋 Changeset detected

Latest commit: 484c957e5747da62dcd636f918cfbcf2decedc79

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@apollo/federation-internals Patch
@apollo/gateway Patch
@apollo/composition Patch
@apollo/query-planner Patch
@apollo/query-graphs Patch
@apollo/subgraph Patch
apollo-federation-integration-testsuite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 28 '24 22:06 changeset-bot[bot]

Deploy Preview for apollo-federation-docs processing.

Name Link
Latest commit cb89af1ef46b060136ce5edba6de890de431fecb
Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/667f3386bd48fb00086f2d28

netlify[bot] avatar Jun 28 '24 22:06 netlify[bot]

Deploy Preview for apollo-federation-docs ready!

Name Link
Latest commit 484c957e5747da62dcd636f918cfbcf2decedc79
Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/669578a6d5bfba0008885529
Deploy Preview https://deploy-preview-3057--apollo-federation-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 28 '24 22:06 netlify[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Jun 28 '24 22:06 codesandbox-ci[bot]