federation icon indicating copy to clipboard operation
federation copied to clipboard

Fix message for when override conflicts with other directives

Open lukassailer opened this issue 2 years ago • 3 comments

When working with the override directive i received this error (names changed): @override cannot be used on field "myType.myField" on subgraph "mySubgraph" since "myType.myField" on "mySubgraph" is marked with directive "@requires" But requires was used on "myOtherSubgraph".

I changed the error message to state the correct subgraph and changed the tests to match the expected behavior.

lukassailer avatar Feb 23 '24 08:02 lukassailer

Deploy request for apollo-federation-docs pending review.

Visit the deploys page to approve it

Name Link
Latest commit 2e3a35bf0182c56b647c77fb797b4d8d91f1bb7a

netlify[bot] avatar Feb 23 '24 08:02 netlify[bot]

⚠️ No Changeset found

Latest commit: 2e3a35bf0182c56b647c77fb797b4d8d91f1bb7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 23 '24 08:02 changeset-bot[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Feb 23 '24 08:02 codesandbox-ci[bot]

Did i miss something that causes circleci to fail? If so please let me know.

lukassailer avatar Mar 06 '24 10:03 lukassailer