federation icon indicating copy to clipboard operation
federation copied to clipboard

executeFetch: fix entities loop condition

Open erankor opened this issue 2 years ago • 5 comments

Something small that I noticed while looking at the code: the loop iterates on receivedEntities, not entities. normally the two arrays will have the same length, however if the condition if (representation && representation[TypeNameMetaFieldDef.name]) is skipped, receivedEntities will contain fewer elements than entities.

erankor avatar Jul 01 '23 13:07 erankor

@erankor: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

apollo-cla avatar Jul 01 '23 13:07 apollo-cla

Deploy request for apollo-federation-docs pending review.

Visit the deploys page to approve it

Name Link
Latest commit 9baf46e5572002103e2de7c8f408925dac6b8685

netlify[bot] avatar Jul 01 '23 13:07 netlify[bot]

⚠️ No Changeset found

Latest commit: 9baf46e5572002103e2de7c8f408925dac6b8685

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 01 '23 13:07 changeset-bot[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Jul 01 '23 13:07 codesandbox-ci[bot]

Thanks for raising this issue! Could you provide a test so we can reproduce this problem?

jeffjakub avatar Jul 11 '23 21:07 jeffjakub