apollo-server

apollo-server copied to clipboard

I was following the [error masking guide](https://www.apollographql.com/docs/apollo-server/data/errors/#masking-and-logging-errors) and trying to pass-through UNAUTHENTICATED errors to the client. Noticed that the client always received INTERNAL_SERVER_ERROR, even when formatError was simply `return error;`....

dandv

I assume that how that the issue is closed this comment should be removed https://github.com/ardatan/graphql-tools/issues/671

maasencioh

The first argument to this.get and other verbs must be non-null.

1

`resolveURL` function in apollo-datasource-rest/src/RESTDataSource.ts (https://github.com/apollographql/apollo-server/blob/39e678c58f984a52c8d5299449c333bda9f1e0be/packages/apollo-datasource-rest/src/RESTDataSource.ts#L76) calls `path.startsWith('/')` therefore `path` must be non-null (as can also be seen in Typescript definition of `RequestOptions`). However, there're use cases where only root url...

yossisp

Improve consistency

2

Just renamed some variables in the docs. This is how it's used in most places across the docs. Doesn't really matter, but improves readability a little imo.

NeoTheThird

Include link to FireSource, a datastore that wraps Firebase Firestore REST APIs.

devskope

Fix example code for applying express middleware. The example code in the docs did not work for me. The submitted code works with `[email protected]` and `[email protected]`. Reference: https://github.com/apollographql/apollo-server/issues/1998#issuecomment-443507700

cseas

fixing a misleading `datasources` casing typo

1

If this is referencing the native Apollo DataSources mechanism I believe it the argument option should be `dataSources` and not `datasources`

divideby0

Add example of tracking user in onDisconnect callback. See https://github.com/apollographql/apollo-server/issues/1597 and https://github.com/apollographql/subscriptions-transport-ws/issues/95 for details.

SergeNarhi

Response example matches mutation name

2

This request fixes an name mismatch in the "Schema basics" tutorial. The section which focuses on creating explicit types for mutations references an earlier mutation which updates the user's email....

nandisc

The original code would work from pure node.js. However, typescript's `lib.es2015.promise.d.ts` requires explicitly passing one non-optional argument for `resolve`. Actually passing `undefined` has the same effect as the original code.

jjangga0214