apollo-server

apollo-server copied to clipboard

EngineReportingOptions.rewriteError hides error subtypes

11

First of all, huge thanks for taking my original PR further and implementing `rewriteError` in https://github.com/apollographql/apollo-server/pull/2618! 🙇 I was trying to get `rewriteError` to work with our Apollo Engine integration,...

lpgera

usage reporting: switch to stripIgnoredCharacters

1

The usage reporting signature algorithm wants to throw away whitespace and other ignored characters. It currently does this via a hacky set of regexp replacements. This PR changes it to...

glasser

RESTDataSource delete method doesn't accept body param

8

https://github.com/apollographql/apollo-server/blob/master/packages/apollo-datasource-rest/src/RESTDataSource.ts#L180 this method doesn't have body param to pas to request. could you add it? there's no reason to not support it because delete request supports it: https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/DELETE I know...

redmundas

apollo-server-lambda Never Shows GraphQL Playground

1

Hi there, I am using serverless to deploy with `apollo-server-lambda`, but the version I am using is: `.3.5.0`. However, even when I set the playground settings to `true`, or with...

ngoctranfire

Add @types/node as dependency to apollo-server-core

1

The `apollo-server-core` package references Node types and should therefore have a dependency on `@types/node`. Here are the errors I am getting using Yarn PnP: ``` ../../.yarn/__virtual__/apollo-server-core-virtual-983f73c0e4/0/cache/apollo-server-core-npm-3.5.0-874d4d1222-4640428267.zip/node_modules/apollo-server-core/dist/nodeHttpToRequest.d.ts:1:23 - error TS2688: Cannot...

Methuselah96

Fix a corner case for Fastify with both path and prefix defined for the app

3

`apollo-server-fastify` currently uses `path` property of `server.createHandler()` options as a prefix for registering a Fastify route. So the problem occurs if one uses `/` as the `path` and uses a...

treble-snake

chore: Reproduction template repo

1

Create a reproduction repo for AS issues. Benefits: 1. Typescript 2. Renovate 3. Clonable or CodeSandbox-able straight from git `main`. Having CI / Renovate doing the gardening is a big...

trevor-scheer

Feat/async formatters [formatError, formatResponse]

3

## Context I want to use internationalization inside the formatError, because I don't want to pass the context to translate the message for all the resolvers when I could just...

greguintow

Get docs-examples renovate happy

2

Let's iterate on the docs-examples renovate config until all PRs are merged and future PRs can be auto-merged. This might include setting up a bit of CI to make sure...

glasser

willResolveField end hook not guaranteed to be called before end of execution

2

willResolveField end hooks (which at least are sync) are called from this special `whenResultIsFinished` on the result of a resolver. But that's in parallel with the processing done on that...

glasser