apollo-server
apollo-server copied to clipboard
checkpoint for downlevel-dts
This is an attempt at addressing #6423. However, it sure seems like
typesVersions
is kinda janky and doesn't work as well as we'd like.
One particular thing I've found is that it doesn't play well with the
../dist
lines we have in our package.json files, because it only gets
applied if the previously resolved path is under the directory it is in:
https://github.com/microsoft/TypeScript/blob/7b764164ede080afff02ec731dfea72b3f4f73f3/src/compiler/moduleNameResolver.ts#L1942
(Yeah, the typesVersions clauses are not consistent across all of the
files here: I was doing a test that only looked at the top-level and
/standalone
ones so those are the ones I was iterating on.)
It's possible this is fixable but maybe we should just bump the TS requirement to v4.7.
⚠️ No Changeset found
Latest commit: c2b1c8a012eace7cdafece99a958d3634d4ad82c
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Deploy Preview for apollo-server-docs ready!
Name | Link |
---|---|
Latest commit | c2b1c8a012eace7cdafece99a958d3634d4ad82c |
Latest deploy log | https://app.netlify.com/sites/apollo-server-docs/deploys/62da4e2dd8659400086f295c |
Deploy Preview | https://deploy-preview-6716--apollo-server-docs.netlify.app/migration |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit c2b1c8a012eace7cdafece99a958d3634d4ad82c:
Sandbox | Source |
---|---|
Apollo Server Typescript | Configuration |
Apollo Server | Configuration |
Giving up on this.