apollo-server
apollo-server copied to clipboard
apollographql
Add calls to `startApolloServer` in docs examples
These examples don't work "out-of-the-box". To some, it might not be obvious that the startApolloServer function must be called to take effect.
Fixes #6464
Deploy Preview for apollo-server-docs ready!
| Name | Link |
|---|---|
| Latest commit | 4b0f010759bce66ca1bbc5d317a4ad082df49ca9 |
| Latest deploy log | https://app.netlify.com/sites/apollo-server-docs/deploys/628bd75a79cf07000861ef74 |
| Deploy Preview | https://deploy-preview-6465--apollo-server-docs.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 4b0f010759bce66ca1bbc5d317a4ad082df49ca9:
| Sandbox | Source |
|---|---|
| Apollo Server Typescript | Configuration |
| Apollo Server | Configuration |
![codesandbox-ci[bot] avatar](https://avatars.githubusercontent.com/in/38409?v=4 "Published by a pub.dev verified publisher"){kind=small}
Took a whole army of complaints to simply update your documentation with one line of code.
You Apollo guys even closed my issue a few days ago, asking me for code when i specifically told them that their documentation was all failing. ONE LINE OF CODE.
I want to be more of as a**hole right now, but there are always other alternatives to pages with "Selecting Package to use" with dead instructions. Just add a 'Dead liftoff ' as well to the docs.
Am done with this 'tool'
It is unfortunate that "how do you call an async function from the top level of a file?" isn't a simple question with a single simple answer in the Node ecosystem, but that's the world we live in.
@rkoron007 have we decided we're comfortable with top-level await in examples? I think you made similar changes in other docsets.
We are comfortable with top-level awaits in the docs now! So, I think the move here is to remove these unnecessary startApolloServer functions and instead insert this note on pages where we currently use top-level awaits. That way, folks know how to enable top-level await if they haven't done so already.
I can make a PR for that @trevor-scheer if you agree that sounds like the way to move forward.
Sounds great @rkoron007! Will you close this one out when you do that please?
Closing this one in favor of https://github.com/apollographql/apollo-server/pull/7124