apollo-rs

apollo-rs copied to clipboard

Converting directive arguments to a struct

2

I often write code like this: ```rust let ty: ExtendedType = ...; let arg: Option = ty.directives.get("directive_name") .and_then(|directive| directive .argument_by_name("arg") .and_then(|arg| arg.as_str())); ``` It gets tedious when doing that for...

Geal

query language for database's executable definitions

2

Would kind of be interesting to explore querying executable definition types with a smaller query language that we can use in the database. Given a schema: ```graphql interface Pet {...

lrlna

Split off from https://github.com/apollographql/apollo-rs/issues/608 The draft GraphQL spec adds a new feature: https://spec.graphql.org/draft/#sec-String-Value.Escape-Sequences > For legacy reasons, a [supplementary character](https://www.unicode.org/glossary#supplementary_character) may be escaped by two fixed-width unicode escape sequences forming...

SimonSapin

Currently we only support `\u1234`, but the draft spec adds `\u{12345678}` syntax. We should add support for that in the lexer and the parser. https://spec.graphql.org/draft/#EscapedUnicode

goto-bus-stop

TypeDefinition should implement lightweight identity hashing rather than `derive(Hash)`

2

The `TypeDefinition` enum derives the `Hash` trait, which is extremely slow for large types. For example, this simple wrapper struct that just hashes typename provides a dramatic improvement when inserting...

gmac

Let's say an operation is added as a source to the compiler. Instead of working with the provided version of the operation, we'd like to work with a slightly changed...

lrlna

No parsing syntax error for variables in constant values

1

## Description The following should produce a syntax error, as variables cannot be used in constant value positions: ```graphql query($id1: ID, $id2: ID = $id1) { __typename } ``` Apollo...

gmac

We moved from miette to ariadne so we can create diagnostics that reference multiple files at once. This caused one major regression in our diagnostic display: ariadne often prints way...

goto-bus-stop

semantic diff between graphql documents

8

There have been a few asks to be able to check whether two documents are semantically the same. Here are some things that I think would not matter when checking...

lrlna

Improve parser error formatting

7

ref https://github.com/apollographql/apollo-rs/pull/347#discussion_r1020325156 Right now parser errors show the index and the current token it's looking at, which isn't all that helpful to end users. IIRC Simon mentioned using the Python...

goto-bus-stop