apollo-link icon indicating copy to clipboard operation
apollo-link copied to clipboard

Published 20 hours ago • verified publisher icon apollographql

[Feature] Allow configuration to strip unnecessary characters

Open SaschaDens opened this issue 5 years ago • 6 comments

This is a pull request related to the issue #1079 which adds a new option to remove unnecessary characters in the query field in order to save bandwidth (neglectable?) and cleaner GET queries.

TODO:

  • [x] Make sure all of new logic is covered by tests and passes linting
  • [x] Update CHANGELOG.md with your change

SaschaDens avatar Jan 26 '20 11:01 SaschaDens

@SaschaDens: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

apollo-cla avatar Jan 26 '20 11:01 apollo-cla

Codecov Report

Merging #1241 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1241      +/-   ##
==========================================
+ Coverage    95.6%   95.62%   +0.01%     
==========================================
  Files          22       22              
  Lines        1116     1119       +3     
  Branches      174      163      -11     
==========================================
+ Hits         1067     1070       +3     
  Misses         44       44              
  Partials        5        5
Impacted Files Coverage Δ
packages/apollo-link-http-common/src/index.ts 93.05% <100%> (+0.3%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f3dcc8b...5ffb312. Read the comment docs.

codecov-io avatar Jan 26 '20 11:01 codecov-io

Can we please get this merged?

atombender avatar Mar 09 '20 01:03 atombender

Echoing what @atombender said! Possible to get this in soon please? 🙏

exsuzme avatar Mar 31 '20 18:03 exsuzme

@SaschaDens, can you please sign the CLA? Many people are waiting for your contribution to be merged. Otherwise, how to proceed when there's no response from the OP?

aprilmay avatar Apr 30 '20 22:04 aprilmay

@SaschaDens, can you please sign the CLA? Many people are waiting for your contribution to be merged. Otherwise, how to proceed when there's no response from the OP?

@aprilmay the CLA has been signed, as far as I can remember from the beginning when I've created this PR. I've re-signed the CLA just to be sure.

@hwillson is there something missing for this PR in order to proceed?

SaschaDens avatar May 01 '20 05:05 SaschaDens