apollo-ios icon indicating copy to clipboard operation
apollo-ios copied to clipboard

Published 20 hours ago • verified publisher icon apollographql

Default the `RequestChain` to run on background thread

Open engali94 opened this issue 1 year ago • 3 comments

RequestChain causing performance regression because it is called on the main thread

engali94 avatar Sep 29 '22 20:09 engali94

@engali94: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

apollo-cla avatar Sep 29 '22 20:09 apollo-cla

Deploy request for apollo-ios-docs pending review.

Visit the deploys page to approve it

Name Link
Latest commit 5b7df5f12d2f24ce8b9f82feae532dfe343e9223

netlify[bot] avatar Sep 29 '22 20:09 netlify[bot]

Hi @engali94, there are unfortunately many other places that default to using .main as the callback queue. I think the change to correctly resolve this across the whole stack needs to be more comprehensive than just the one line.

calvincestari avatar Sep 30 '22 06:09 calvincestari

I'm closing this PR due to inactivity. If the rest of the solution is added at any point we're happy to reconsider it - thank you.

calvincestari avatar Oct 28 '22 19:10 calvincestari