apollo-ios-dev icon indicating copy to clipboard operation
apollo-ios-dev copied to clipboard

Published 20 hours ago • verified publisher icon apollographql

Remove double async dispatch queue call on failure

Open sean-escendant opened this issue 6 months ago • 5 comments

sean-escendant avatar May 19 '25 09:05 sean-escendant

@sean-escendant: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

apollo-cla avatar May 19 '25 09:05 apollo-cla

Deploy request for apollo-ios-docc pending review.

Visit the deploys page to approve it

Name Link
Latest commit 7f88441d2028fffd64a65b7d6bb0a62802255a6b

netlify[bot] avatar May 19 '25 09:05 netlify[bot]

It looks like you didn't add a description to your pull request. Please edit and add as much detail as possible for the reviewers. Pull requests require a description before they will be reviewed - thank you.

github-actions[bot] avatar May 19 '25 09:05 github-actions[bot]

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 7d56fcaef4da8c5bb7221553

svc-apollo-docs avatar May 19 '25 09:05 svc-apollo-docs

@calvincestari you see any issue with this?

I'll take a better look at this PR tomorrow but if it is a double call then merging shouldn't be an issue.

calvincestari avatar May 19 '25 16:05 calvincestari

@sean-escendant - thanks for the contribution but we cannot merge this PR until you sign the Apollo CLA.

calvincestari avatar May 20 '25 17:05 calvincestari

@BobaFetters - this code seems correct. I'm not a fan of how queues are used in the websocket transport. The sooner we get to rewriting that the better. Gotta wait for the CLA to be signed before we can merge though.

calvincestari avatar May 20 '25 17:05 calvincestari

@sean-escendant - thanks for the contribution but we cannot merge this PR until you sign the Apollo CLA.

Sorry I don't want to provide my mailing address to sign the CLA. Perhaps a future version of the CLA will allow anonymous contributors.

sean-escendant avatar May 21 '25 18:05 sean-escendant

@sean-escendant, unfortunately Apollo cannot accept contributions without a signed CLA. That means I'll need to close this PR without merging it.

We can push the change forward still but it will need to be done by a contributor who has signed the CLA, or by one of the Apollo iOS maintainers.

calvincestari avatar May 21 '25 19:05 calvincestari