apollo-ios-dev icon indicating copy to clipboard operation
apollo-ios-dev copied to clipboard

fix: Local cache mutation generation when field merging disabled

Open calvincestari opened this issue 6 months ago • 3 comments

Fixes https://github.com/apollographql/apollo-ios/issues/3554

The full set of selection set initializers must always be generated for local cache mutation operations and fragments. Before this change using a fieldMerging policy of anything other than none would generate local cache mutations but they could not be initialized and did not contain all the correct merged fields.

calvincestari avatar May 16 '25 21:05 calvincestari

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: da0721188710ec689bb12df0

svc-apollo-docs avatar May 16 '25 21:05 svc-apollo-docs

Deploy Preview for apollo-ios-docc canceled.

Name Link
Latest commit 53512be4dba7f7baa0f8a6144fee5b2515d929f5
Latest deploy log https://app.netlify.com/projects/apollo-ios-docc/deploys/6837a1a47e7ec70008f8543c

netlify[bot] avatar May 16 '25 21:05 netlify[bot]

@BobaFetters - take a look at this one too if you'd like. I'll wait for @AnthonyMDev to review too before merging.

calvincestari avatar May 19 '25 16:05 calvincestari

OK @AnthonyMDev - ready for another review.

calvincestari avatar May 28 '25 23:05 calvincestari

We're going to be handling the propagating of mutable status to fragments in a separate PR right?

Correct. I'm working on that one now. It'll be layered on top of this PR but this one can be merged before. I'd like to get them both merged before publishing the next release though.

calvincestari avatar May 29 '25 17:05 calvincestari