apollo-ios-dev icon indicating copy to clipboard operation
apollo-ios-dev copied to clipboard

fix Array JSONEncodable

Open arnauddorgans opened this issue 2 years ago • 2 comments

Avoid using fatal error on JSONEncodable instead of conforming protocol with where clause

arnauddorgans avatar Nov 08 '23 19:11 arnauddorgans

Hmmm... I wanted to do this ages ago, and there was some reason why I couldn't. I think it was causing some build errors.

We're going to need to test this manually on iOS versions pre 14.4. I'm wondering if the issues I saw before had to do with the conversion of the nested AnyHashable types inside of the array (which doesn't work properly on iOS < 14.4).

Thanks for the PR. Give me some time to look into this a bit further before we pull it in.

AnthonyMDev avatar Nov 08 '23 21:11 AnthonyMDev

Do you need help with something?

AndersonMartins1 avatar Mar 09 '24 10:03 AndersonMartins1

Deploy request for apollo-ios-docc pending review.

Visit the deploys page to approve it

Name Link
Latest commit ae78d9771ded75052fc2a684ec88b9f19dacc970

netlify[bot] avatar Jul 29 '24 18:07 netlify[bot]

Deploy request for eclectic-pie-88a2ba pending review.

Visit the deploys page to approve it

Name Link
Latest commit ae78d9771ded75052fc2a684ec88b9f19dacc970

netlify[bot] avatar Jul 29 '24 18:07 netlify[bot]