apollo
apollo copied to clipboard
add an option to custom oidc userDisplayName
What's the purpose of this PR
add an option for custom oidc userDisplayName claimName
Which issue(s) this PR fixes:
Fixes #3795 #4498
Brief changelog
- add a property
spring.security.oidc.user-display-name-claim-name
to custom the claimName of the userDisplayName - add the
getFullName
as a fallback of thegetPreferredUsername
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Read the Contributing Guide before making this pull request.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit tests to verify the code.
- [x] Run
mvn clean test
to make sure this pull request doesn't break anything. - [x] Update the
CHANGES
log.
Codecov Report
Merging #4507 (46c2c91) into master (82db184) will decrease coverage by
0.10%
. The diff coverage is0.00%
.
:exclamation: Current head 46c2c91 differs from pull request most recent head 9bcbbbb. Consider uploading reports for the commit 9bcbbbb to get more accurate results
@@ Coverage Diff @@
## master #4507 +/- ##
============================================
- Coverage 53.47% 53.36% -0.11%
+ Complexity 2707 2704 -3
============================================
Files 492 494 +2
Lines 15393 15419 +26
Branches 1595 1598 +3
============================================
- Hits 8231 8228 -3
- Misses 6605 6634 +29
Partials 557 557
Impacted Files | Coverage Δ | |
---|---|---|
...lo/portal/spi/configuration/AuthConfiguration.java | 8.33% <0.00%> (ø) |
|
...portal/spi/configuration/OidcExtendProperties.java | 0.00% <0.00%> (ø) |
|
...i/oidc/OidcAuthenticationSuccessEventListener.java | 0.00% <0.00%> (ø) |
|
...ork/apollo/portal/spi/oidc/OidcUserInfoHolder.java | 0.00% <0.00%> (ø) |
|
...ework/apollo/portal/spi/oidc/OidcUserInfoUtil.java | 0.00% <0.00%> (ø) |
|
...work/apollo/biz/message/DatabaseMessageSender.java | 56.25% <0.00%> (-8.34%) |
:arrow_down: |
.../apollo/internals/RemoteConfigLongPollService.java | 77.24% <0.00%> (-1.20%) |
:arrow_down: |
...mework/apollo/portal/component/PortalSettings.java | 70.31% <0.00%> (+4.68%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Looks great! Shall we also add some instructions in the oidc related documents?
Looks great, would you please also help to update the en doc?