apollo icon indicating copy to clipboard operation
apollo copied to clipboard

Is this judgment valid?

Open zhuxindong opened this issue 2 years ago • 1 comments

https://github.com/apolloconfig/apollo/blob/471f59dee1b24664c9d622f6c8e457cb12631dda/apollo-client/src/main/java/com/ctrip/framework/apollo/internals/AbstractConfig.java#L102

like this test case:

Config config = ConfigService.getConfig("someConfig")
while(true){
    config.addChangeListener(new ConfigChangeListner(){
    @Override
    public void onChange(ConfigChangeEvent event){
      //do something
}
}
}

consider override equals() methode in apollo-client/src/main/java/com/ctrip/framework/apollo/ConfigChangeListener.java

zhuxindong avatar Jul 13 '22 03:07 zhuxindong

That I think is all right as they are different listeners.

nobodyiam avatar Jul 14 '22 00:07 nobodyiam

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 14 '22 00:08 stale[bot]

This issue has been automatically closed because it has not had activity in the last 7 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.

stale[bot] avatar Aug 31 '22 07:08 stale[bot]