apollo
apollo copied to clipboard
chore: use Google Java Format to format Java code automaticlly by github action
What's the purpose of this PR
Auto format Java code when people push or pull request.
Which issue(s) this PR fixes:
Fixes #4196
Brief changelog
- Add a workflow
.github/workflows/google-java-format.yml
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Read the Contributing Guide before making this pull request.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit tests to verify the code.
- [x] Run
mvn clean test
to make sure this pull request doesn't break anything. - [x] Update the
CHANGES
log.
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅
Codecov Report
Merging #4200 (16c62bc) into master (96ee53a) will increase coverage by
0.01%
. The diff coverage isn/a
.
:exclamation: Current head 16c62bc differs from pull request most recent head 1d73cc1. Consider uploading reports for the commit 1d73cc1 to get more accurate results
@@ Coverage Diff @@
## master #4200 +/- ##
============================================
+ Coverage 52.56% 52.58% +0.01%
- Complexity 2623 2625 +2
============================================
Files 484 484
Lines 15200 15200
Branches 1571 1571
============================================
+ Hits 7990 7993 +3
+ Misses 6651 6650 -1
+ Partials 559 557 -2
Impacted Files | Coverage Δ | |
---|---|---|
.../framework/apollo/spring/property/SpringValue.java | 89.47% <0.00%> (+1.75%) |
:arrow_up: |
...rk/apollo/spring/property/SpringValueRegistry.java | 89.18% <0.00%> (+5.40%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 96ee53a...1d73cc1. Read the comment docs.
@apolloconfig/committers
Is it possible let @github-actions sign the CLA?
@apolloconfig/committers
Is it possible let @github-actions sign the CLA?
What about add github-actions to this JSON file directly?
@apolloconfig/committers
Is it possible let @github-actions sign the CLA?
@Anilople @zouyx We could add github-actions
to allowlist as shown below to skip cla check.
https://github.com/apolloconfig/apollo/blob/0e4542e4153bd4660dd1af6084ea4a1e9a9d17fe/.github/workflows/cla.yml#L40
@apolloconfig/committers Is it possible let @github-actions sign the CLA?
@Anilople @zouyx We could add
github-actions
to allowlist as shown below to skip cla check.https://github.com/apolloconfig/apollo/blob/0e4542e4153bd4660dd1af6084ea4a1e9a9d17fe/.github/workflows/cla.yml#L40
Done.
@Anilople It looks like we need to submit a standalone pull request to add github-actions
to allowlist first or it won't be effective for this pull request.
recheck
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 14 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 14 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 14 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!