Thrift-Swift icon indicating copy to clipboard operation
Thrift-Swift copied to clipboard

TJSONProtocol support to Thrift-Swift package

Open HojjatK opened this issue 1 year ago • 1 comments

I needed to use TJSONProtocol for a project and hence forked and implemented the json protocol in the following fork:

https://github.com/HojjatK/Thrift-Swift

Note that I have ported the code from C# lib to Swift, the code works fine for me However I need to add more unit-tests What's the process of If I want to send a pull-request so that it will be part of the official package?

Thank you Hojjat

HojjatK avatar Mar 06 '23 07:03 HojjatK

I sent a Pull-Request from https://github.com/cozality which its email account is linked with my work account.
https://github.com/cozality/Thrift-Swift

The PR addressed the following (mentioned in Read.me)

TJSONProtocol - This will need to be implemented

cozality avatar May 19 '23 18:05 cozality