docker-modem icon indicating copy to clipboard operation
docker-modem copied to clipboard

Set default `hijack` option to true

Open phaseOne opened this issue 3 years ago • 1 comments

I'm on Docker Desktop for ARM Mac 4.11.1 (84025) and I'm experiencing an issue with dockerode, where writing to stdin never reaches the process in my container.

Based on moby/moby#43799, it seems a change in Docker Desktop 4.10.0 requires that the Connection and Upgrade headers be sent for stream multiplexing to work, since Docker Desktop proxies the docker socket.

phaseOne avatar Sep 09 '22 00:09 phaseOne

I'm not sure if changing this default would be a good idea.

There's a lot of use cases beside Docker Desktop, I would love more opinions on this one.

apocas avatar Dec 26 '22 21:12 apocas