Pedro Dias

Results 53 comments of Pedro Dias

Passes: https://github.com/apocas/dockerode/blob/master/test/docker.js#L648 Fails: https://github.com/apocas/dockerode/blob/master/test/docker.js#L658 So we can't just remove the stringify. Add that parameter as an exception?

But we can't just remove this condition because the are endpoints expecting the data "stringifed". Like https://github.com/apocas/dockerode/blob/master/test/docker.js#L658 On the other hand there are parameters that are expected by Docker to...

Everything seems ok from this side. You seem to be respecting https://docs.docker.com/engine/api/v1.41/#operation/NetworkConnect Not sure whats failing on the docker side.

SSH2 bumped and published on docker-modem v3.0.6

Can't replicate this, can you provide an example script?

Not sure about the impact of this. Won't we be hitting false positives? (ex: data with error key) This may be a breaking change, there may be people already doing...

Interesting, curious about the underlying cause. docker-engine's HTTP management isn't the great also, so it could also be a problem there. Nevertheless going to implement a simple/nasty control to ensure...

Possibly same as https://github.com/apocas/dockerode/issues/538 Are you using followProgress?