Alexander Plavin

These PRs and the potential differences were discussed in #63. @jw3126 touched on the implementation side, but there's also a design difference. In my opinion, "Query" from #23 shouldn't be...

That's exactly what we did with getall :) Code in this PR is indeed typestable, but still not very efficient. It calls `getall` way too many times than should be...

That's true, `Recursive` is specifically out of scope here due to compiler not being that smart. For me this is totally fine, as most getall/setall usecases are with plain non-recursive...

See my new update: - `getall` implementation simplified - type-stable and pretty reasonable (I think) `setall` implementation Comments and suggestions welcome!

I really like how neatly everything works together: ```julia julia> using Accessors, ForwardDiff, StaticArrays # arbitrary function that takes an object julia> f(x) = exp(x.a.b) - x.a.c # differentiate wrt...

I think this use case can best be solved with a function like `objf_closure_to_modifiable_optic(closure)`. It should return a struct that wraps the closure and has `Accessors.modify()` defined in terms of...

> but it depends on the context whether one wants to make that part of an interface. The only issue is user convenience. My suggestion was precisely to make it...

@giordano yes, that's indeed the case. Never heard of `Base.skip` before, and had to use `Base.skip(...) = ...` instead of just `skip(...) = ...` after finding that it exists.

name similarity looks totally fine for me, please merge... 3 days have passed

Maybe I'm somewhat out of the loop, but don't see major issues with piracy turning a methoderror into working code. Clearly, there are packages doing these things already. Different story...