apitrace icon indicating copy to clipboard operation
apitrace copied to clipboard
verified publisher icon apitrace

minor fixes and additions

Open Slaw6820 opened this issue 1 year ago • 4 comments

During my work with apitrace I have encountered a small number of issues that were addressed with the following changes to the source code. Please review.

Slaw6820 avatar Dec 31 '23 20:12 Slaw6820

Hello @Slaw6820

thank you for the contribution, could you split the one commit into the separate changes?

okias avatar Jan 01 '24 15:01 okias

Sure. Does it mean that all proposed fixes are accepted? Should I create multiple changes under one PR or separate PRs?

Slaw6820 avatar Jan 02 '24 12:01 Slaw6820

Sure. Does it mean that all proposed fixes are accepted? Should I create multiple changes under one PR or separate PRs?

LTGM, but I'm not an biggest authority here :) just commits within this MR :)

okias avatar Jan 02 '24 13:01 okias

@jrfonseca

Slaw6820 avatar Jan 05 '24 18:01 Slaw6820