Alan Pinstein

Review status: 0 of 6 files reviewed at latest revision, 2 unresolved discussions. --- _[a discussion](https://reviewable.io:443/reviews/apinstein/jqjobs/32#-KMa1UxxouxdizOpsCu5:-KMa1UxxouxdizOpsCu6:-1150297321) (no related file):_ The other arch q is -- read my README changes about...

@woofyman99 here's the PR for the JQJobs workers for multiple queues --- Review status: 0 of 8 files reviewed at latest revision, 2 unresolved discussions. --- _Comments from [Reviewable](https://reviewable.io:443/reviews/apinstein/jqjobs/32#-:-KMddkvjwnVykpcVDvdp:-1698461837)_

Review status: all files reviewed at latest revision, 6 unresolved discussions. --- _[a discussion](https://reviewable.io:443/reviews/apinstein/jqjobs/32#-KMa1UxxouxdizOpsCu5:-KMdzh3qc8U9WjY5pdPA:-128593879) (no related file):_ Previously, leftdevel (Oscar Balladares M.) wrote… > Sounds sane to me, though maybe...

Review status: 5 of 8 files reviewed at latest revision, 6 unresolved discussions. --- _[a discussion](https://reviewable.io:443/reviews/apinstein/jqjobs/32#-KMa1UxxouxdizOpsCu5:-KMeP4lUdJLTrfXn6dCS:-1321364224) (no related file):_ Previously, apinstein (Alan Pinstein) wrote… > I'd expect no BC issues;...

@leftdevel can you check out this PR now? I think it's good-to-go. ``` [X] Test JQStore->next(NULL) finds next job available on all queues [X] Test JQStore->next('a') finds next job available...

Review status: all files reviewed at latest revision, 2 unresolved discussions. --- _[src/JQJobs/JQWorker.php, line 151 [r6]](https://reviewable.io:443/reviews/apinstein/jqjobs/32#-KMiyHJNH0a5lTE32wVz:-KMj2p6eVvYk0dYz1jOG:-1708429800) ([raw file](https://github.com/apinstein/jqjobs/blob/def364cc46084c84cafe8e277603aa4aee3e3c08/src/JQJobs/JQWorker.php#L151)):_ Previously, leftdevel (Oscar Balladares M.) wrote… > This trick feels a bit...

Review status: all files reviewed at latest revision, 2 unresolved discussions. --- _[src/JQJobs/JQStore/Array.php, line 82 [r6]](https://reviewable.io:443/reviews/apinstein/jqjobs/32#-KMixmSHDVt5-0d6pIDC:-KMj30ctAuPgtYYQqZSn:1685254440) ([raw file](https://github.com/apinstein/jqjobs/blob/def364cc46084c84cafe8e277603aa4aee3e3c08/src/JQJobs/JQStore/Array.php#L82)):_ Previously, leftdevel (Oscar Balladares M.) wrote… > There is no check for...

Review status: all files reviewed at latest revision, 1 unresolved discussion. --- _[src/JQJobs/JQWorker.php, line 151 [r6]](https://reviewable.io:443/reviews/apinstein/jqjobs/32#-KMiyHJNH0a5lTE32wVz:-KMjWV_MO1D9JMO0VXyH:1392641249) ([raw file](https://github.com/apinstein/jqjobs/blob/def364cc46084c84cafe8e277603aa4aee3e3c08/src/JQJobs/JQWorker.php#L151)):_ Previously, leftdevel (Oscar Balladares M.) wrote… > Oui. If you remove the...

Review status: all files reviewed at latest revision, 2 unresolved discussions. --- *[a discussion](https://reviewable.io:443/reviews/apinstein/jqjobs/32#-KXppXV-7sJ3t_6KyLW-:-KXppXV-7sJ3t_6KyLW0:b-tsfs3c) (no related file):* UPDATE: This PR was never merged as the client of JQJobs decided it...

This would be a nice default option but I don't think our workloads warrant it presently.