Andrew Pinski

Results 82 comments of Andrew Pinski

I see you also added about lists there; I am ok with both changes.

This can be addressed afterwards but how would be the best way to specify an header union without any valid headers? I would have assumed we could do the following...

Are the "+=" operators two tokens or just one? That is can you do: a + = b; or does it need to be without whitespaces? a += b; The...

> We should also make sure that this won't introduce conflicts in the bison parser (mostly likely not). It won't because statements are defined as: lvalue = expression lvalue (...

Note something is going on with the draft HTML generation though, see https://github.com/p4lang/p4-spec/issues/1175 . The released spec 1.2.3 is correct.

Here are my thoughts and even how I would have done the original control plane based arguments. Having directionless meaning two different things is definitely confusing. I would have used...

I am trying to remember if we have a case where a lvalue expression can have a side effect which will need to be handled correctly in the specifications and...

> Solved by #1074 Huh? No that is a different feature request unrelated to this one. That only just solves `f(a = _);` for the call. I am asking for...

To me constructor parameters are like non-type template arguments in C++ and such. Maybe the thing to do is change all compile time know values to constant expressions instead and...

Related to https://github.com/p4lang/p4-spec/issues/876