platform icon indicating copy to clipboard operation
platform copied to clipboard

Devops package update/eslint fix

Open lazy-developer opened this issue 6 years ago • 2 comments

Closes #

Changes

Describe your changes here as a bulleted list:

  • package json update
  • probably fixing eslint issues

Developer checklist

This checklist is to be completed by the PR developer:

  • [ ] Alternative solutions were compared/discussed before writing code
    • [ ] trade-offs with this solution are considered acceptable
  • [ ] Code in this PR adheres to the project styleguide
  • [ ] This pull request does not decrease project test coverage
  • [ ] If the code changes existing database collection(s), migration has been written
  • [ ] If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @username1

This list is to be completed by the pull request reviewer:

  • [ ] Code works as described/expected
  • [ ] Code seems to be error free
    • [ ] no browser console errors visible
    • [ ] no server console errors visible
    • [ ] passes CI build
  • [ ] Code is written in a way that promotes maintainability
    • [ ] easy to understand
    • [ ] well organized
    • [ ] follows project coding standards and conventions
    • [ ] well documented

lazy-developer avatar Jul 04 '19 11:07 lazy-developer

Hi, almost there :D we need to downgrade d3 or fix the issue: TypeError: d3.time is undefineddc.js:371 when I run the project

ilarimikkonen avatar Jul 05 '19 07:07 ilarimikkonen

d3 is fine

ilarimikkonen avatar Jul 09 '19 09:07 ilarimikkonen