node-irsdk icon indicating copy to clipboard operation
node-irsdk copied to clipboard

Developer support

Open iamisti opened this issue 4 years ago • 6 comments

Hi there!

I'm very extremely happy to have this package open sourced. It would be great if we developers could contribute to your project, but unfortunately there is no description about how to set up a development environment, and how to compile everything to check if things are working properly.

For example I'm having problems with node version, because in some c headers there is still the old node reference and so it cannot be used with other version of nodes.

Would be great if you can extend the readme for some developer support! I'd love to join and help you out.

iamisti avatar Nov 21 '19 08:11 iamisti

@iamisti et al; I would be keen to help as well.

On a side note: I was already contemplating either writing a TS declaration file OR converting this project completely to TS. I think long term there is benefit in that, as many big projects are making the switch, so the tools are getting better, and a lot more people use TS as a starting point.

I dont think that would be a pointless refactor as it really helps integrate the library into your own project without having to read lots of doc.

Would anyone be interested in that?

joshystuart avatar Dec 02 '19 20:12 joshystuart

@crimsonronin going to fork this project and write the TS bindings. Working on a dashboard app using this sdk. if you make the fork I can contribute to your fork if that works.

rators avatar Dec 17 '19 22:12 rators

Sounds good @rators! Have you started either the dashboard or the bindings yet?

joshystuart avatar Dec 18 '19 04:12 joshystuart

Not sure if you guys already started on the typescript things but here is my declaration file: https://gist.github.com/sabifa/d64c38a996304bd72f3af90564724d43

I'm sure there are things missing, I'm just starting out with typescript but so far it works as expected for my projects using the package! 😅

sabifa avatar Apr 23 '20 05:04 sabifa

Nice one @sabifa !

I haven't had time to do anything related to this unfortunately. But I'm keen to try out your bindings. Maybe you could even make a package out of it so we can consume it and contribute back via PRs?

joshystuart avatar Apr 26 '20 22:04 joshystuart

Yes that would make sense, but where would I put this package? It would be nice to include it directly with this repo, but it seems like the maintainer is quite busy at the moment and can't spend much time on it. Maybe here?

sabifa avatar Apr 28 '20 06:04 sabifa