terraform-modules icon indicating copy to clipboard operation
terraform-modules copied to clipboard

Published 20 hours ago • verified publisher icon apigee

Add sample module for Apigee Provisioning without VPC Peering

Open baskaran-md opened this issue 1 year ago • 1 comments

Apigee announced the GA launch of its non-VPC provisioning option

  • Add sample modules for provisioning Apigee without VPC Peering.

    • Made network & ip_ranges as optional variables in apigee-x-core module.

  • [x] I tested the provisioning locally and is successful.

  • [x] I have followed the relevant style guide for my changes.

baskaran-md avatar Sep 07 '24 01:09 baskaran-md

Thanks for the PR, Baskaran. Let me review and merge this.

g-greatdevaks avatar Sep 09 '24 05:09 g-greatdevaks

@danistrebel / @g-greatdevaks - Please review the PR again.

  • [X] Added PSC + XLB setup.
  • [X] Added test @ tests/samples/test_x_non_vpc_peering.py
  • [X] Recreated the docs using re-create the docs for all modules with the script in ./tools/format-repo.sh. FYI - It formatted few other files that I didn't modify as well.

baskaran-md avatar Oct 25 '24 16:10 baskaran-md

Thanks @baskaran-md ,

The last thing that the pipeline complains about in https://github.com/apigee/terraform-modules/actions/runs/11522276251/job/32260268126?pr=159 are the following README files.

The Documentation in the following README files is out of date:
/github/workspace/modules/apigee-x-core/README.md
/github/workspace/samples/x-non-vpc-peering/README.md

Do you mind re-running the TF docs tool for these two modules?

otherwise all LGTM!

danistrebel avatar Oct 30 '24 08:10 danistrebel