apigee-edge-drupal icon indicating copy to clipboard operation
apigee-edge-drupal copied to clipboard

Published 20 hours ago • verified publisher icon apigee

POC: Render app credential warnings with BigPipe

Open mxr576 opened this issue 2 years ago • 4 comments

This solves Problem 1 from #944.

mxr576 avatar Oct 11 '23 14:10 mxr576

So this is the first version of the solution and it is subject to changes, especially around wording.

The main idea that we would keep the old way until 4.0.0 because downstream projects may (and most probably) customized how app credentials are rendered.

Also, if you would wonder, this also works without Big Pipe having enabled, it just renders everything synchronously, so we do not need to make it a requirement - maybe a warning on admin/reports/status page for that would be useful if it is not enabled.

mxr576 avatar Oct 11 '23 14:10 mxr576

@divya-intelli @giteshk what is your opinion about the suggested approach? Does this PR worth to be continued? Anything that you would change on the base idea?

mxr576 avatar Nov 07 '23 21:11 mxr576

@divya-intelli @giteshk what is your opinion about the suggested approach? Does this PR worth to be continued? Anything that you would change on the base idea?

@mxr576 , its good to have this feature which will speed up the page. Thank you and appreciate for your time. We will review once the PR is ready.

divya-intelli avatar Nov 08 '23 07:11 divya-intelli