apigee-edge-drupal
apigee-edge-drupal copied to clipboard
Use FieldAttributeConverterInterface instead of concrete class for constructor injection
Fixes #1198
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Codecov Report
:x: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.54%. Comparing base (4eb37ee) to head (a21d7b8).
:warning: Report is 1 commits behind head on 4.x.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/Form/DeveloperAttributesSettingsForm.php | 0.00% | 5 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## 4.x #1199 +/- ##
=========================================
Coverage 43.54% 43.54%
Complexity 3074 3074
=========================================
Files 343 343
Lines 11253 11253
=========================================
Hits 4900 4900
Misses 6353 6353
| Files with missing lines | Coverage Δ | |
|---|---|---|
| src/Form/DeveloperAttributesSettingsForm.php | 0.00% <0.00%> (ø) |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.