apigee-edge-drupal icon indicating copy to clipboard operation
apigee-edge-drupal copied to clipboard

Fixes PHPCS issues for phpstan v12.4

Open kedarkhaire opened this issue 1 year ago • 1 comments

PHPCS fix includes the following fixes

  1. Use statement sort in alphabetically order
  2. Parameter has null default value, but is not marked as nullable.

kedarkhaire avatar Sep 25 '24 08:09 kedarkhaire

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.97%. Comparing base (34bef3f) to head (62a5d29). Report is 1 commits behind head on 3.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #1085      +/-   ##
============================================
- Coverage     44.20%   42.97%   -1.23%     
  Complexity     3041     3041              
============================================
  Files           342      342              
  Lines         11110    11110              
============================================
- Hits           4911     4775     -136     
- Misses         6199     6335     +136     

see 22 files with indirect coverage changes

codecov[bot] avatar Sep 25 '24 09:09 codecov[bot]

Commands used to analyze and fix the PHPCS issues

  1. Fix code style issues & apply automatic code style fixes with PHPCBF. vendor/bin/phpcbf --standard=web/modules/contrib/apigee_edge/phpcs.xml.dist web/modules/contrib/apigee_edge -s --colors

  2. Check remaining code style issues with PHPCS and fix them manually. vendor/bin/phpcs --standard=web/modules/contrib/apigee_edge/phpcs.xml.dist web/modules/contrib/apigee_edge -p -s -n --colors

Thanks!

kedarkhaire avatar Sep 26 '24 14:09 kedarkhaire