apigee-edge-drupal icon indicating copy to clipboard operation
apigee-edge-drupal copied to clipboard

Adding patch for field core module

Open kedarkhaire opened this issue 1 year ago • 3 comments

Fixes #1057

kedarkhaire avatar May 27 '24 17:05 kedarkhaire

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 27.90%. Comparing base (740605c) to head (0b10eb3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                3.x    #1058   +/-   ##
=========================================
  Coverage     27.90%   27.90%           
  Complexity     3041     3041           
=========================================
  Files           342      342           
  Lines         11111    11111           
=========================================
  Hits           3101     3101           
  Misses         8010     8010           

codecov[bot] avatar May 27 '24 18:05 codecov[bot]

Just as in previous occasion, I am really uncertain if this module should install a patch on Drupal core. Applying a patch on a project can fail for many reasons,like "incorrect" Drupal core version or conflicting patches applied already.

Probably it would be enough documenting this as a known issue and suggesting downstream projects to install the latest patch from the D.o issue if they are affected.

mxr576 avatar May 28 '24 08:05 mxr576

Hi @mxr576 Yes noted your point, we will be mentioning the changes on documentation only. Also this patch will be applied on devportal composer project only for D10.2 i.e. on 10x branch.

kedarkhaire avatar May 29 '24 13:05 kedarkhaire