sway
sway copied to clipboard
Allow array parameter default value
Previously schema.default tag for schema.type === array was never processed and only schema.items.default were usable.
Do you mind adding a unit test? Ideally one that fails prior to your change and then passes after. Also, when preparing your commit run gulp
to not only run the tests and lint the code but to also generate the browser files.
Thanks for the follow up with #139 I ll close this one.
Is it possible to update the release so npm gets the #139?
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
- If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
- In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.
I'm in the process of clearing out the issues/PRs. As soon as that's done, I'll cut a release.