swagger-tools
swagger-tools copied to clipboard
apigee-127
fixes stream validation
What is the failure for this? Can you wire up an error handler and dump the whole object? (This isn't as easy as JSON.stringify(err), you'll need to write a function to map over the error keys and build the object that way.)
uh, i don't know what you mean. err is null by the way. the problem is, that the response body does not equal the file content. im simply using the hash function of the crypto module to create a comparable hash for the content of the file and the response data.
Oh, I got you. I thought stream validation was throwing an error where it wasn't suppose to. Let me look further.
awh, please! timeout on node 0.12. srsly?! how can i retrigger travis tests?
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.
@whitlockjc can you please have a look at master? it seems that the tests fail recently. i checked it out and performed it locally and the same errors occur as of this PR. Thanks
I'll fix master and when I do, you'll need to rebase this. I don't know what's up with the CLA showins as "failed".
Would you mind submitting something similar for sway? I assume it's got the same issue.
@whitlockjc can you please help merge this? this resolve my problem,before that,i can not pipe or res.download(get corrupt file ),with this pull,i can get correct file thanks!
