swagger-test-templates icon indicating copy to clipboard operation
swagger-test-templates copied to clipboard

Update to [email protected] causes failing tests

Open ssteinerx opened this issue 8 years ago • 0 comments

I did a:

npm run test

to get started with this package and noticed the following deprecation warnings when installing dependencies:

npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated [email protected]: to-iso-string has been deprecated, use @segment/to-iso-string instead.
npm WARN deprecated [email protected]: Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

Updated only the eslint dependency to the latest (3.12.2) from ^0.24.1 (released way back here: @nzakas nzakas released this on Jul 10, 2015 · 2904 commits to master since this release).

Now, with the new eslint (and no more deprecation warnings), eight tests fail. They're all of the same form:

  1) deprecated swagger assert-option expect should have path parameters with an obvious indicator:
     AssertionError: expected [ Array(3) ] to have a length of 0 but got 3
      at Function.assert.lengthOf (node_modules/chai/lib/chai/interface/assert.js:1086:37)
      at Context.<anonymous> (test/deprecated/test.js:75:20)

Being new to this package, I have not the slightest clue what this test is supposed to do or how to fix it but it seems that pulling eslint up to a new version and getting rid of NPM deprecation warnings, and fixing or eliminating these tests if they're no longer needed would be a reasonable thing to do in any case.

ssteinerx avatar Dec 17 '16 02:12 ssteinerx