fingerprint-suite icon indicating copy to clipboard operation
fingerprint-suite copied to clipboard

fix: "BrowserType" type

Open k725 opened this issue 10 months ago • 1 comments

Fixed the incorrect type. For example, the following example from the README will result in a type error.

https://github.com/apify/fingerprint-suite/blob/master/packages/header-generator/README.md?plain=1#L27-L42

Code

    const generator = new HeaderGenerator({
      browsers: [{ minVersion: 90, name: 'firefox' }, { minVersion: 110, name: 'chrome' }, 'safari'],
      devices: ['desktop'],
      operatingSystems: ['windows'],
    });

Error

TS2322: Type { minVersion: number; name: 'firefox'; } is not assignable to type 'chrome' | 'firefox' | 'safari' | 'edge'

k725 avatar Apr 18 '24 06:04 k725

@barjin Hi, how can I proceed with this PR?

k725 avatar May 03 '24 15:05 k725

ah, sorry, I must have missed this.

Looks good to me! Thank you for your contribution!

barjin avatar May 20 '24 13:05 barjin