crawlee icon indicating copy to clipboard operation
crawlee copied to clipboard
verified publisher icon apify

Run unit tests on Windows

Open janbuchar opened this issue 10 months ago • 3 comments

  • Currently, running unit tests on Windows is not part of our CI pipeline
  • This causes issues like getMemoryInfo always returning a placeholder value to go unnoticed (see https://github.com/apify/crawlee/issues/2771#issuecomment-2642523641)

janbuchar avatar Feb 07 '25 13:02 janbuchar

I am afraid this will have a pretty negative effect on the CI, windows in CI is terribly slow and flaky, so if we are to do this, I would at least keep the checks optional.

B4nan avatar Feb 07 '25 14:02 B4nan

I mean, we already run tests on windows in crawlee-python. You are right that they are like 50-100% slower than on Linux, but we live with that.

janbuchar avatar Feb 07 '25 14:02 janbuchar

I thought we still ran tests on windows, just not required for PRs to be merged (as windows has been consistently unstable) 👀

vladfrangu avatar Feb 07 '25 15:02 vladfrangu