crawlee icon indicating copy to clipboard operation
crawlee copied to clipboard
verified publisher icon apify

Rename constants prefixed `SDK_` to `CRAWLEE_`

Open mnmkng opened this issue 2 years ago • 2 comments

Which package is the feature request for? If unsure which one to select, leave blank

None

Feature

It would be great to have this updated.

Motivation

CleanShot 2023-01-03 at 18 41 41@2x

Ideal solution or implementation, and any additional constraints

rename

Alternative solutions or implementations

No response

Other context

No response

mnmkng avatar Jan 03 '23 17:01 mnmkng

Do you think it's safe to do it in a non-major release? I know those are internals, but I can imagine people reading those files manually too. Thoughts @metalwarrior665?

B4nan avatar Jan 03 '23 18:01 B4nan

I think it would be safer to wait for a major release. It's not critical.

mnmkng avatar Jan 04 '23 06:01 mnmkng