crawlee icon indicating copy to clipboard operation
crawlee copied to clipboard

Docs not correct for JSON in CheerioCrawler and other docs issues

Open mnmkng opened this issue 3 years ago • 2 comments

The docs say that you need to add json to the additionalMimeTypes, but that's not true. I'd fix it, but we need to check it in HTTP crawler as well plus build and update the v3 of docs to release it, so I'm making an issue instead.

https://github.com/apify/crawlee/blob/e7b8c629bcaeb4570f41fcbbc27b870d83249f65/packages/http-crawler/src/internals/http-crawler.ts#L355

mnmkng avatar Aug 25 '22 12:08 mnmkng

It seems that some functions are reported as methods and some as properties?

CleanShot 2022-08-25 at 14 48 25

mnmkng avatar Aug 25 '22 12:08 mnmkng

It seems that some functions are reported as methods and some as properties?

This will be resolved by #1550, it depends on the signature, e.g. foo(): any vs foo: () => any.

B4nan avatar Sep 19 '22 20:09 B4nan