crawlee-python icon indicating copy to clipboard operation
crawlee-python copied to clipboard

Naming `BrowserPlugin` vs `BrowserFactory`

Open vdusek opened this issue 8 months ago • 0 comments

  • Naming browsers/browser_plugin.py vs browsers/browser_factory.py (or BrowserControllerFactory).
  • "Plugin" is the old name and doesn't quite fit the current use case. "Factory," on the other hand, seems to be a better fit, as the class has only one public method for producing BrowserControllers, along with initialization and destruction. However, we would need to update this in the TypeScript version as well.
  • This is a follow-up to the issue discussed in this pull request comment.

vdusek avatar Jun 10 '24 14:06 vdusek