crawlee-python icon indicating copy to clipboard operation
crawlee-python copied to clipboard

Improve the deduplication of requests

Open vdusek opened this issue 8 months ago • 1 comments

Context

A while ago, Honza Javorek raised some good points regarding the deduplication process in the request queue (#190).

The first one:

Is it possible that Apify's request queue dedupes the requests only based on the URL? Because the POSTs all have the same URL, just different payload. Which should be very common - by definition of what POST is, or even in practical terms with all the GraphQL APIs around.

In response, we improved the unique key generation logic in the Python SDK (PR #193) to align with the TS Crawlee. This logic was lates copied to crawlee-python and can be found in crawlee/_utils/requests.py.

The second one:

Also wondering whether two identical requests with one different HTTP header should be considered same or different. Even with a simple GET request, I could make one with Accept-Language: cs, another with Accept-Language: en, and I can get two wildly different responses from the same server.

Currently, HTTP headers are not considered in the computation of unique keys. Additionally, we do not offer an option to explicitly bypass request deduplication, unlike the dont_filter option in Scrapy (docs).

Questions

  • Should we include HTTP headers in the unique_key (extended_unique_key) computation?
  • Should we implement a dont_filter feature?
  • Should use_extended_unique_key be set as the default behavior?

vdusek avatar Jun 10 '24 09:06 vdusek