browser-pool icon indicating copy to clipboard operation
browser-pool copied to clipboard

Published 20 hours ago • verified publisher icon apify

fix: support puppeteer v14.4+

Open B4nan opened this issue 2 years ago • 6 comments

Closes #78

B4nan avatar Jul 01 '22 16:07 B4nan

@B4nan Do you have a rough ETA when this will get merged & released?

corford avatar Jul 11 '22 10:07 corford

Its weird that the CI fails so hard, especially ubuntu tests that are usually less flaky than windows ones.

The priority is now crawlee release, which should happen on wednesday, so I hope there will be some time for this one afterwards (it is already addressed in @crawlee/browser-pool@next).

B4nan avatar Jul 11 '22 10:07 B4nan

@B4nan Gentle ping to ask if this is still planned to be merged?

corford avatar Sep 06 '22 09:09 corford

Have you tried @crawlee/browser-pool? We could ship one last version, but given the failing tests I would rather not.

I could definitely offer merging this, which will ship a new beta version, I am just a bit affraid of releasing new stable.

B4nan avatar Sep 06 '22 11:09 B4nan

Have you tried @crawlee/browser-pool?

Yep, we're currently targetting @crawlee/browser-pool (and puppeteer v15) via an apify overrides block in packages.json. Seeing some instability with page crashes on certain sites. It might not be related though - haven't had time to debug yet.

Understand your reluctance to role a new stable. A beta would be super helpful though 👍 (we'll start our migration effort over to Crawlee soon anyway, so this is only a temporary bandaid).

corford avatar Sep 06 '22 11:09 corford

Ok will try to get back to this during the week and merge at least parts of it. We merged puppeteer 17.0 support to crawlee just yesterday, so it would be good to bump it here too.

(we are holding from 17.1 as it might not be compatible with latest stable chrome)

B4nan avatar Sep 06 '22 12:09 B4nan