browser-pool icon indicating copy to clipboard operation
browser-pool copied to clipboard

prePageCreateHooks examples are missing the pageOptions param.

Open petrpatek opened this issue 4 years ago • 4 comments

I would add the parameter to the examples too. For example, I searched the number of params, and I would fail to find the third one.

petrpatek avatar Feb 09 '21 19:02 petrpatek

@petrpatek can you add this please when you're looking into adding the fingerprint injector?

mnmkng avatar Oct 04 '21 14:10 mnmkng

I noticed that there is probably old build logic for docs that supports only javascript, or am I missing something?

petrpatek avatar Oct 10 '21 13:10 petrpatek

Not sure. @szmarczak you made some changes to the docs right? Does the build still work or is it fully manual now?

Also @petrpatek please coordinate with @szmarczak on https://github.com/apify/browser-pool/issues/52 as it is connected to this issue.

mnmkng avatar Oct 10 '21 13:10 mnmkng

No idea, I haven't touched doc builds at all. So I guess @petrpatek is right. Last time I checked I had to replace src with dist or something else in the script.

szmarczak avatar Oct 10 '21 14:10 szmarczak