apify-sdk-js icon indicating copy to clipboard operation
apify-sdk-js copied to clipboard

fix: esm builds

Open ryanleecode opened this issue 1 year ago • 1 comments

#322

ryanleecode avatar Sep 03 '24 02:09 ryanleecode

Thanks for the PR, but we won't be merging this one, definitely not in such shape. If we are to change the monorepo setup, we will handle it ourselves, we are not interested in a complete rewrite like this. Also I hope you don't expect us to merge a PR that is doing so many things at once, including changing package manager, and doing many breaking changes like changing the TS configs completely.

I will leave it open, as I feel like parts of it might be usable at least as an inspiration.

Note that we are considering going ESM native in next major instead of dealing with dual builds (especially since there is now the experimental support for require(esm) in both node 20 and 22). It will likely happen later this year.

B4nan avatar Sep 04 '24 08:09 B4nan

Closing since we already have a first version of v4 available on NPM which is native ESM (code lives in https://github.com/apify/apify-sdk-js/tree/v4 branch).

B4nan avatar Jun 09 '25 14:06 B4nan