apify-sdk-js icon indicating copy to clipboard operation
apify-sdk-js copied to clipboard

feat: [WIP] apify extra

Open barjin opened this issue 3 years ago • 4 comments

barjin avatar Oct 28 '22 10:10 barjin

@barjin Are we still stuck on something or there wasn't the capacity to finalize? I will definitely want to polish the code once more but also would like to do it when we know how to build it :)

metalwarrior665 avatar Nov 29 '22 20:11 metalwarrior665

feel free to review, guess it sort of fizzled out @B4nan ?

btw it's been buildable since the first day, it's all kinda finished now - correctness and usability remain to be checked by someone with more actor-building expertise :)

barjin avatar Nov 29 '22 22:11 barjin

Hah, I didn't even realize you refactored the whole thing and added tests :) Let me just review it and we can release, good job!

metalwarrior665 avatar Jan 09 '23 22:01 metalwarrior665

btw @barjin @B4nan I'm thinking about this one from time to time. Last year, there were only few new projects so there wasn't much need to implement any advanced functionality (and what we needed was fine to copy/paste).

In the end, we can probably just keep copy-pasting for now. If we want to push this through, I think it would be better to do it right into Crawlee, the interface to Dataset is the same and it will bubble into SDK.

The only other one that is used quite frequently is parallelPersistedCall (see example here) which should probably go to the SDK. The client would be cool but it doesn't understand migration which is needed in this case.

metalwarrior665 avatar Apr 11 '23 20:04 metalwarrior665